On Mon, Jul 26, 2010 at 3:21 PM, Matthew Garrett <mjg59@xxxxxxxxxxxxx> wrote: > On Mon, Jul 26, 2010 at 03:15:32PM -0700, Luis R. Rodriguez wrote: >> On Mon, Jul 26, 2010 at 2:25 PM, Matthew Garrett <mjg59@xxxxxxxxxxxxx> wrote: >> > This may need to be done on a chip by chip basis. Take a look at >> > http://www.atheros.cz/inffile.php?inf=68&bit=32&atheros=AR5002G&system=4 >> > and some of the other inf files on that site to see which devices >> > provide the PciASPMOptIn flag - those should support ASPM states even if >> > they're pre-1.1 devices. >> >> I rather we not bother with these, lets simply follow the kernel's >> lead here for its rule matching. > > Sorry? The idea is to indicate which chips support ASPM even though > they're pre-PCIe 1.1. If all Atheros parts work fine with L1 then that > makes things much easier, but it would be good to know the correct set > of chips that are broken with L0s. What I meant was that the PCI config space would already have L1 enabled if L1 worked, so I don't see why we would need to nitpick out specifics here. All Atheros PCIE chips should work with L1. The advise given is to disable L0s though. I believe AR2425 would be one which likely had L0s enabled but requires it to be disabled. Not sure of others. But this is why I am saying this can be done globally for all ath5k chipsets. Luis -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
