On Tue, Jun 22, 2010 at 12:31:27PM +0530, Johannes Berg wrote: > On Tue, 2010-06-22 at 12:08 +0530, Vasanthakumar Thiagarajan wrote: > > > > http://thread.gmane.org/gmane.linux.kernel.wireless.general/51218/focus=51520 > > > > Sorry for a late reply. LED implementation with ath9k is completely > > manual, fully controlled by driver (We have to set/clear a particular > > gpio pin to turn on/off the LED every time). on/off period during blink > > is based on the number of brightness_set() on tx/rx led trigger. Do > > you think your suggested implementation would help in this case too? > > I'm not sure. I was mostly describing the use in iwlwifi, and since I > don't know how ath9k works I can't really comment much. With ath9k hw itself does not blink LED based on the traffic, it is the driver which turns on/off LED based on tx/rx. > It just seemed > to me that the driver was also hard-coding the behaviour of the LEDs, > which the user in that thread didn't like for iwlwifi. Yeah, before Vivek's patch the driver was hard-coding the LED behaviour. After this patch, the behaviour would be based on a modparam. > so integrating > with the LED trigger stuff could be worthwhile for ath9k? Or maybe it > does and I'm reading the patches incorrectly. The existing LED implementation looks simple. As the blink rate is determined in driver dynamically, I'm not quite sure integrating LED trigger, would review this in detail later. Vasanth -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
