Hi, Apologies for the delay in reviewing this. On Thu, 2010-06-03 at 13:44 +0300, Juuso Oikarinen wrote: > @@ -699,6 +704,8 @@ enum ieee80211_smps_mode { > struct ieee80211_conf { > u32 flags; > int power_level, dynamic_ps_timeout, dynamic_ps_forced_timeout; > + int dynamic_ps_user_timeout; > + bool disable_dynamic_ps; > int max_sleep_period; Please don't keep these variables in driver-visible structures, they don't belong there as they are implementation details, they should be in the ieee80211_local structure somewhere and the driver should see _only_ dynamic_ps_timeout. The same actually applies to dynamic_ps_forced_timeout as well, so please also make a separate patch moving that. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html