Search Linux Wireless

Re: [RFC] mac80211: sample survey implementation for mac80211 & hwsim

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Holger,

> > +static int ieee80211_dump_survey(struct wiphy *wiphy, struct net_device *dev,
> > +				 int idx, struct survey_info *survey)
> > +{
> > +	struct ieee80211_local *local = wdev_priv(dev->ieee80211_ptr);
> > +
> > +	if (!local->ops->get_survey)
> > +		return -EOPNOTSUPP;
> 
> The check for the function is duplicated in drv_get_survey. I think the
> wrapper should be called unconditionally.

Please address this comment and add tracing. Your patch was merged, so
that needs to be an add-on patch.

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux