On 05/04/10 19:17, John W. Linville wrote: > On Tue, May 04, 2010 at 05:31:09AM +0200, Gertjan van Wingerde wrote: > >> To be honest, at the moment I would just change the default from 'n' to 'y' >> for one kernel cycle, and then remove the entire option in the next kernel >> release. >> This is just to make it easier to revert back if for some reasons problems >> arise with the rt30xx support. >> The overall goal is to get rid of all these of the RT2800PCI_yyy and RT2800USB_zzz >> symbols, but that can only happen if the devices denoted by these symbols >> are properly supported. >> >> John, I leave it up to you, but for me my original patch should be merged, and >> I'll send an equivalent patch for Stefan's one for the next kernel release. > > Since the options are already inside "if RT2800PCI" and "if RT2800USB" > blocks, I don't see why anyone should object to the boolean defaulting > to 'y'. It's not as if you are enabling a new driver. > > I think Gertjan's proposal seems reasonable -- just don't forget! :-) > I would suggest a feature-removal-schedlue.txt patch, but I don't > know that it is worth the trouble. > Don't worry. I won't forget. I introduced these configuration items simply to be able to disable non-functional devices from the driver. Once all devices are working properly I will remove all of these Kconfig variables. Feature-removal-schedule.txt seems like a lot of overkill, as we are not actually removing features, we are simply unconditionally enabling code. --- Gertjan. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
