On 05/04/10 00:44, Pavel Roskin wrote: > On Tue, 2010-05-04 at 00:08 +0200, Stefan Lippers-Hollmann wrote: > >> RT2800PCI_RT30XX is not a new/ separate module, its only function is to >> limit the PCI ID space (to not claim PCI IDs for chipset generations not >> yet debugged properly) of rt2800pci.ko; this symbol isn't even used >> anywhere else than within the PCI table. > > I realize that. Still, somebody upstream can object. > >> A 100% equivalent patch would be >> to just drop the config option completely. I doubt that doing that would >> meet resistance, as it merely adds previously 'unknown' (to be supported) >> PCI IDs. > > That's what I would do. > To be honest, at the moment I would just change the default from 'n' to 'y' for one kernel cycle, and then remove the entire option in the next kernel release. This is just to make it easier to revert back if for some reasons problems arise with the rt30xx support. The overall goal is to get rid of all these of the RT2800PCI_yyy and RT2800USB_zzz symbols, but that can only happen if the devices denoted by these symbols are properly supported. John, I leave it up to you, but for me my original patch should be merged, and I'll send an equivalent patch for Stefan's one for the next kernel release. --- Gertjan. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
