On Sat, Apr 17, 2010 at 8:34 AM, Kalle Valo <kvalo@xxxxxxxxxx> wrote: > Grazvydas Ignotas <notasas@xxxxxxxxx> writes: > >> wl1251 has WLAN_IRQ pin for generating interrupts to host processor, >> which is mandatory in SPI mode and optional in SDIO mode (which can >> use SDIO interrupts instead). However TI recommends using deditated >> IRQ line for SDIO too. >> >> Add support for using dedicated interrupt line with SDIO, but also leave >> ability to switch to SDIO interrupts in case it's needed. > > For spi the irq number delivered through struct spi_device, I assume > sdio didn't have any similar mechanism and that's why you added it to > struct wl12xx_platform_data. Yes, SDIO currently only reads the card itself for information and doesn't use any board data at all. This is enough for typical SDIO card but not in this case, where we have additional signals for power control and IRQ. > Only minor comment is that it would be better to mention also in the > code that the gpio interrupt is the recommended method. But I can add > that comment later. Will have that in mind too if I send something more, thanks. >> Signed-off-by: Grazvydas Ignotas <notasas@xxxxxxxxx> > > Acked-by: Kalle Valo <kvalo@xxxxxxxxxx> > > Thank you again. > > -- > Kalle Valo > -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
