On Fri, 2010-04-16 at 17:34 -0400, Pavel Roskin wrote: > On Fri, 2010-04-16 at 22:57 +0200, Johannes Berg wrote: > > > We've done it on other drivers -- we can't do it for all of the kernel > > because that would drown people in warnings, but for those drivers that > > _should_ be clean it ought to be fine to add it by default. > > Oh, I see, there are several precedents. > > That said, there are not many warnings added by __CHECK_ENDIAN__. In my > x86_64 configuration, sparse produces 2316 lines of output without > __CHECK_ENDIAN__ and 3526 lines with __CHECK_ENDIAN__, a 52% increase. > That's hardly "drowning". Other people feel differently by that, evidenced by the "lack of enthusiasm" for adding endian checking by default. > Also, the warnings about endianess are perhaps the most useful of all > sparse warnings. I agree, so I want them whenever I run sparse on code I own. However, I'm simply not willing to fight for making endian checking default kernel-wide to achieve that goal. You may disagree, and you're welcome to pick that fight. Until then, please let us do what gets our job done. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
