The sta_cleanup timer is used to expire frames in the sta structure ps_tx_buf -list. To perform this, the timer is executed periodically. The timer is executed periodically, regardless if there are frames in the buffer or not. As a result, the system gets periodically woken up for no reason at all, wasting precious resources. This patch proposes a simple fix. It prevent rescheduling the sta_cleanup timer if on the particular invocation the ps_tx_buf buffers for all sta's were empty. On the TX path, the timer is restarted upon queueing frames to those buffers. Due to the way checking is performed, this approach will "leak" a few unnecessary invocations of the timer handler, but in the big picture those do not matter. Comments are appreciated. Juuso Oikarinen (1): mac80211: Prevent running sta_cleanup timer unnecessarily net/mac80211/sta_info.c | 13 ++++++++++--- net/mac80211/tx.c | 7 +++++++ 2 files changed, 17 insertions(+), 3 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
