Hi,
On Fri, 2010-04-16 at 07:17 +0200, ext Kalle Valo wrote:
> Juuso Oikarinen <juuso.oikarinen@xxxxxxxxx> writes:
>
> > Determine the dynamic PS timeout based on the configured ps-qos network
> > latency. For backwards wext compatibility, allow the dynamic PS timeout
> > configured by the cfg80211 to overrule the automatically determined value.
>
> Thanks. I took a quick look, but I haven't tested this yet myself.
>
> > + timeout = local->hw.conf.dynamic_ps_forced_timeout;
> > + if (timeout < 0) {
> > + if (latency <= 50000)
> > + timeout = 300;
> > + else if (latency <= 2000000000)
> > + timeout = 100;
> > + else
> > + timeout = 0;
> > + }
> > + local->hw.conf.dynamic_ps_timeout = timeout;
>
> What will be the timeout value when there are no pm_qos requirements
> from user space applications? Do you know what will be the default
> latency value in that case?
Yes, the default value is 2000000000 (2000 seconds, ugh.) Hence the
value in the if statement for 100ms.
> I'm mostly worried about timeout 0 case, for example I suspect ath9k
> is broken with that value.
>
> Also does this patch change the default value of dynamic ps timeout?
>
No, the current default does not change. As the default value for the
latency is 2000s, we will, by default, get a timeout of 100ms.
-Juuso
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
