Grazvydas Ignotas <notasas@xxxxxxxxx> writes:
> wl1251 is embedded chip that can be connected using SDIO bus, and is not
> an actual SDIO card. For this reason there is a need to pass some board
> specific data, like 'EEPROM is attached' flag or power control callback.
> However there is no way to pass this data through SDIO subsystem, so
> this patch registers dummy platform_device to allow that.
Thanks a lot, this is really needed. Few comments though:
> +struct wl12xx_platform_data *wl12xx_board_data;
Shouldn't this be static? Also I assume that there is no way to
allocate this dynamically, am I correct?
> @@ -208,6 +240,10 @@ static int __init wl1251_sdio_init(void)
> {
> int err;
>
> + err = platform_driver_register(&wl1251_platform_driver);
> + if (err)
> + wl1251_error("failed to register platform driver: %d", err);
You should exit the function here.
Can you fix the above and resend, please?
--
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
