On Fri, Apr 9, 2010 at 5:12 PM, Pavel Roskin <proski@xxxxxxx> wrote: > On Thu, 2010-04-08 at 15:25 -0400, Luis R. Rodriguez wrote: >> This series adds support for a new chipset family for the ath9k driver, >> the AR9003 harware family. This family of chipsets will includes 2-stream >> and 3-stream devices. We start off by supporting only 2-streams on both >> devices. Both the 2-stream and 3-stream devices are fully functional at >> this point. We have a few more items which we will iron out as part >> of future patches but we're sending this out so that we don't stall >> development on more cleanups/etc. Our delta is already quite large. > > I hope everything went through checkpatch.pl and the result was checked > by sparse. I tried to do it myself, but some patches need to be > updated. Every single patch was tested with sparse v0.4.2, but not checkpatch. We'll double check that. > Considering the huge amount of changes, maybe it would be better to send > the preparatory changes first, which don't refer to AR9003 in any way? > Those could be tested first. Then the rest could be posted. That is what we did, actually. The initial work was a base for abstraction or different families and only after do we start adding AR9003 support. > I like the idea of synchronization with the private HAL, as it means > that more eyeballs will be looking at the same code. But I don't think > we should relax quality requirements. If the private HAL is worse in > any aspect, even in a comment wording, the fix should go to the private > HAL, not to ath9k. Indeed, the AR9003 code should hopefully the last bit of code out of synch. The code quality requirements that we have on Linux *will* be embraced by the private HAL :) Addressing unification between the private Atheros HAL and ath9k is a large undertaking and we do expect to work closely with the community on it. Addressing the unification was just not something we could fit into our tight schedule for integration with ath9k, so it will be done later. Luis -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
