On Fri, Apr 9, 2010 at 4:48 PM, Pavel Roskin <proski@xxxxxxx> wrote: > On Thu, 2010-04-08 at 15:26 -0400, Luis R. Rodriguez wrote: >> Signed-off-by: Luis R. Rodriguez <lrodriguez@xxxxxxxxxxx> >> --- >> drivers/net/wireless/ath/ath9k/ar5008_initvals.h | 1495 ++-- >> drivers/net/wireless/ath/ath9k/ar9001_initvals.h | 2432 +++-- >> drivers/net/wireless/ath/ath9k/ar9002_initvals.h |12659 +++++++++++++--------- >> 3 files changed, 9658 insertions(+), 6928 deletions(-) >> >> diff --git a/drivers/net/wireless/ath/ath9k/ar5008_initvals.h b/drivers/net/wireless/ath/ath9k/ar5008_initvals.h >> index cd953f6..ba899f9 100644 >> --- a/drivers/net/wireless/ath/ath9k/ar5008_initvals.h >> +++ b/drivers/net/wireless/ath/ath9k/ar5008_initvals.h >> @@ -18,725 +18,856 @@ >> #define INITVALS_AR5008_H >> >> static const u32 ar5416Modes[][6] = { >> - { 0x00001030, 0x00000230, 0x00000460, 0x000002c0, 0x00000160, 0x000001e0 }, > ... >> + {0x00001030, 0x00000230, 0x00000460, 0x000002c0, 0x00000160, >> + 0x000001e0}, > > That's hardly an improvement. > > Actually, it should be possible to strip the first 4 zeroes from the > first value (the register number), and then there will be no wrapping. > > The only exceptions are > > { 0x00020010, 0x00000003 }, > { 0x00020038, 0x000004c2 }, > > in ar5416Common_9100. They look suspicious, by the way. But even > stripping 3 zeroes should be enough. Good idea. Luis -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html