Search Linux Wireless

Re: [PATCH] mac80211: check whether scan is in progress before queueing scan_work

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2010-04-06 at 11:06 +0200, Johannes Berg wrote:

> > -	if (list_empty(&local->work_list) && local->scan_req)
> > +	mutex_lock(&local->scan_mtx);
> > +
> > +	if (list_empty(&local->work_list) && local->scan_req &&
> > +	    !local->scanning)
> >  		ieee80211_queue_delayed_work(&local->hw,
> >  					     &local->scan_work,
> >  					     round_jiffies_relative(0));
> >  
> > +	mutex_unlock(&local->scan_mtx);
> > +
> >  	mutex_unlock(&local->work_mtx);
> 
> That really doesn't look right ... at all.

Oops, confused the two locks.

Still though, wouldn't the scan work simply not do anything?

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux