Hi, On Thu, Apr 1, 2010 at 11:44 PM, Gertjan van Wingerde <gwingerde@xxxxxxxxx> wrote: > Luis, > > On 04/01/10 23:14, Luis Correia wrote: >> The ralink SoC platforms do not have an MCU. >> >> Signed-off-by: Luis Correia <luis.f.correia@xxxxxxxxx> > > I know Ivo already acked the v2 version of the patch, but isn't the > addition of a driver flag a bit overkill? > > We have the test on whether the platform is SOC w.r.t. MCU requests > in 2 places, and both of them are in rt2800 code. I do not really see > a need to clutter the global rt2x00 space with a rt2800 specific flag, > which is only used in rt2800 code. I suggested the new flag to Luis. I wonder if a case exists where the driver has no firmware but does need MCU access. I already considered it strange when Ralink released a chip without firmware while other revisions did need it. If this combination would be extremely unlikely, then we can indeed remove the flag. Ivo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
