On Wednesday 31 March 2010 21:39:35 John W. Linville wrote:
> diff --git a/drivers/ssb/pci.c b/drivers/ssb/pci.c
> index 9e50896..a4b2b99 100644
> --- a/drivers/ssb/pci.c
> +++ b/drivers/ssb/pci.c
> @@ -620,6 +620,11 @@ static int ssb_pci_sprom_get(struct ssb_bus *bus,
> int err = -ENOMEM;
> u16 *buf;
>
> + if (!ssb_is_sprom_available(bus)) {
> + ssb_printk(KERN_ERR PFX "No SPROM available!\n");
> + return -ENODEV;
> + }
Note that in ssb_pci_init() you might also want to add such a check to avoid
registering the "sprom" sysfs file in case there's no sprom. Otherwise root is
able to crash the machine via that file. Same goes for ssb_pci_exit(), of course.
--
Greetings, Michael.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
