Search Linux Wireless

Re: [RFC PATCHv5 2/2] mac80211: Add support for connection quality monitoring

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2010-03-19 at 10:03 +0200, Juuso Oikarinen wrote:

> + * @IEEE80211_HW_SUPPORTS_CQM:
> + *	Hardware can do connection quality monitoring - i.e. it can monitor
> + *	connection quality related parameters, such as the RSSI level and
> + *	provide notifications if configured trigger levels are reached.

It doesn't really matter at this point, before we have any other CQM
data point implementations, but I would expect this to be CQM_RSSI,
CQM_BEACON_LOSS etc. in different flags eventually since not all might
be supported and one might want to allow some w/o the others?

> +static int ieee80211_set_cqm_config(struct wiphy *wiphy,
> +				    struct net_device *dev,
> +				    s32 rssi_thold, u8 rssi_hyst)
> +{
> +	struct ieee80211_sub_if_data *sdata = IEEE80211_DEV_TO_SUB_IF(dev);
> +	struct ieee80211_local *local = wdev_priv(dev->ieee80211_ptr);
> +	struct ieee80211_vif *vif = &sdata->vif;
> +	struct ieee80211_bss_conf *bss_conf = &vif->bss_conf;
> +
> +	if (vif->type != NL80211_IFTYPE_STATION)
> +		return -EOPNOTSUPP;

I think this check should probably be in cfg80211, it really doesn't
make sense in any other mode.

I'm sorry for making you go through iterations over and over again!

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux