Search Linux Wireless

Re: [RFC PATCHv3 2/2] mac80211: Add support for connection quality monitoring

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2010-03-17 at 17:19 +0100, ext Johannes Berg wrote:
> On Wed, 2010-03-17 at 15:01 +0200, Juuso Oikarinen wrote:
> 
> > --- a/include/net/mac80211.h
> > +++ b/include/net/mac80211.h
> > @@ -599,6 +599,7 @@ enum ieee80211_conf_flags {
> >   * @IEEE80211_CONF_CHANGE_RETRY_LIMITS: retry limits changed
> >   * @IEEE80211_CONF_CHANGE_IDLE: Idle flag changed
> >   * @IEEE80211_CONF_CHANGE_SMPS: Spatial multiplexing powersave mode changed
> > + * @IEEE80211_CONF_CHANGE_CQM: Connection quality monitor config changed
> >   */
> >  enum ieee80211_conf_changed {
> >  	IEEE80211_CONF_CHANGE_SMPS		= BIT(1),
> > @@ -609,6 +610,7 @@ enum ieee80211_conf_changed {
> >  	IEEE80211_CONF_CHANGE_CHANNEL		= BIT(6),
> >  	IEEE80211_CONF_CHANGE_RETRY_LIMITS	= BIT(7),
> >  	IEEE80211_CONF_CHANGE_IDLE		= BIT(8),
> > +	IEEE80211_CONF_CHANGE_CQM		= BIT(9),
> >  };
> >  
> >  /**
> > @@ -662,6 +664,9 @@ enum ieee80211_smps_mode {
> >   *    frame, called "dot11ShortRetryLimit" in 802.11, but actually means the
> >   *    number of transmissions not the number of retries
> >   *
> > + * @cqm_rssi_thold: Connection quality monitor RSSI threshold
> > + * @cqm_rssi_hyst: Connection quality monitor RSSI hysteresis
> > + *
> >   * @smps_mode: spatial multiplexing powersave mode; note that
> >   *	%IEEE80211_SMPS_STATIC is used when the device is not
> >   *	configured for an HT channel
> > @@ -676,6 +681,9 @@ struct ieee80211_conf {
> >  
> >  	u8 long_frame_max_tx_count, short_frame_max_tx_count;
> >  
> > +	s32 cqm_rssi_thold;
> > +	u8 cqm_rssi_hyst;
> 
> You probably don't care all that much, but I have a feeling this should
> be part of the per-BSS data not the global configuration data, since
> especially when we do it in software we could have to deal with multiple
> virtual interfaces.

Good point, for the wl12x1 it doesn't matter so much as they can only
support one virtual interface. I'll change this.

-Juuso

> 
> johannes
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux