On Wed, 2010-03-17 at 17:17 +0100, ext Johannes Berg wrote: > On Wed, 2010-03-17 at 15:01 +0200, Juuso Oikarinen wrote: > > > +/** > > + * enum nl80211_cqm_state - current state in relation to set threshold > > + * @NL80211_CQM_STATE_ABOVE: the level is above the configured threshold > > + * @NL80211_CQM_STATE_BELOW: the level is below the configured threshold > > + */ > > +enum nl80211_cqm_state { > > + NL80211_CQM_STATE_ABOVE, > > + NL80211_CQM_STATE_BELOW, > > +}; > > Thoughts about removing this and just exporting the actual (smoothed?) > RSSI instead in the event? Or do you simply not get that from the hw? On the wl1271 we actually do get the value that triggered the event, but on the wl1251, for instance, we do not get it. On the wl1271 we get to decide the above/below on the host based on the reading, but the wl1251 will just tell the host that now the RSSI went below, and now it just went above. Our thinking is that the above/below information is sufficient to make a decisions about roaming. Adding the literal value will give trouble with HW not supporting it. If you feel the actual value of the RSSI would be important, we could add it as an optional field to the notifcation in addition to the above/below. -Juuso > johannes > -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html