On Mon, Mar 15, 2010 at 5:05 PM, Felix Fietkau <nbd@xxxxxxxxxxx> wrote: > On 2010-03-16 12:55 AM, Luis R. Rodriguez wrote: >> On Mon, Mar 15, 2010 at 4:52 PM, Felix Fietkau <nbd@xxxxxxxxxxx> wrote: >>> On 2010-03-16 12:49 AM, Luis R. Rodriguez wrote: >>>> diff --git a/drivers/net/wireless/ath/ath9k/hw.c b/drivers/net/wireless/ath/ath9k/hw.c >>>> index 00570fb..867cfaf 100644 >>>> --- a/drivers/net/wireless/ath/ath9k/hw.c >>>> +++ b/drivers/net/wireless/ath/ath9k/hw.c >>>> @@ -807,6 +804,10 @@ void ath9k_hw_init_global_settings(struct ath_hw *ah) >>>> acktimeout += 64 - sifstime - ah->slottime; >>>> >>>> ath9k_hw_setslottime(ah, slottime); >>>> + >>>> + if (AR_SREV_9271(ah)) >>>> + return; >>>> + >>>> ath9k_hw_set_ack_timeout(ah, acktimeout); >>>> ath9k_hw_set_cts_timeout(ah, acktimeout); >>>> if (ah->globaltxtimeout != (u32) -1) >>> >>> Why leave out the ACK/CTS timeout setting? How does the hw handle ACK >>> and CTS timeouts? >> >> Right, so that's why I originally removed this hunk completely, I was >> under the impression you latest fix would have addressed any issues >> but it does not, we get association time outs. I think we'll have to >> review this further in order to support coverage class. > Are you sure the slot time was set properly by the callback? Well ath9k_htc did not have it implemented, I just added the code for it, you know what.. I did not test modifying the ACK/CTS timeout *and* with the new slot time code I added to ath9k_htc, let me try that. > Can you > print out the values that it's setting? Yeah, 20 upon initial association and then I see another setting for 9. > The initvals for 9271 don't > really look all that different. Indeed, odd... this should work with the fudge factor you added. Luis -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
