Search Linux Wireless

Re: [PATCH v3 00/12] ath9k_hw: complete support for AR9271

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2010-03-16 12:55 AM, Luis R. Rodriguez wrote:
> On Mon, Mar 15, 2010 at 4:52 PM, Felix Fietkau <nbd@xxxxxxxxxxx> wrote:
>> On 2010-03-16 12:49 AM, Luis R. Rodriguez wrote:
>>> diff --git a/drivers/net/wireless/ath/ath9k/hw.c b/drivers/net/wireless/ath/ath9k/hw.c
>>> index 00570fb..867cfaf 100644
>>> --- a/drivers/net/wireless/ath/ath9k/hw.c
>>> +++ b/drivers/net/wireless/ath/ath9k/hw.c
>>> @@ -807,6 +804,10 @@ void ath9k_hw_init_global_settings(struct ath_hw *ah)
>>>               acktimeout += 64 - sifstime - ah->slottime;
>>>
>>>       ath9k_hw_setslottime(ah, slottime);
>>> +
>>> +     if (AR_SREV_9271(ah))
>>> +             return;
>>> +
>>>       ath9k_hw_set_ack_timeout(ah, acktimeout);
>>>       ath9k_hw_set_cts_timeout(ah, acktimeout);
>>>       if (ah->globaltxtimeout != (u32) -1)
>>
>> Why leave out the ACK/CTS timeout setting? How does the hw handle ACK
>> and CTS timeouts?
> 
> Right, so that's why I originally removed this hunk completely, I was
> under the impression you latest fix would have addressed any issues
> but it does not, we get association time outs. I think we'll have to
> review this further in order to support coverage class.
Are you sure the slot time was set properly by the callback? Can you
print out the values that it's setting? The initvals for 9271 don't
really look all that different.

- Felix
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux