On Tue, Mar 2, 2010 at 12:28 AM, Sujith <Sujith.Manoharan@xxxxxxxxxxx> wrote: > Luis R. Rodriguez wrote: >> So you still don't like a common module approach? I guess I can wait >> to see your patch. > > I don't know, Luis. > It seems a bit cleaner to me, just ath.ko, ath9k_hw.ko and ath9k.ko Well I agree, if some common code exists though it should just go into a module, and if its real small to some inline helpers but from the looks of it that is not the case. > But I don't really care, anyway - maybe we can just dump this series and > use ath9k_common.ko as such. > > I'll send patches removing lib.c from ath9k_htc. Well so my goal with ath9k_common was to use it as a place holder was we don't have common mac80211 helpers between both ath9k and ath9k_htc but with an end goal that we try to merge as much as is possible. I only got to completing basic legacy RX support on ath9k_htc so did only get that far to see the extend to what things can be shared as far as mac80211 callbacks are concerned. >> Year I hear you, so there are two things I think we can do in the long >> run to bring in mac80211 helpers together. The first one is to remove >> the ath9k wiphy. The second is to use a threaded ISR and change our >> bottom halves to use a workqueue instead of a tasklet so we can also >> sleep during our work. I think these two things should enable us to >> start sharing some callbacks. But ath9k virtual wiphy seems to provide >> some functionality we don't yet have in mac80211/cfg80211 centrally >> but we could work on that. > > My vote is to keep the drivers separate. You would be more familiar with the commonality between ath9k and ath9k_htc at this point. Even though the two drivers are separate right now, say we did remove the ath9k virtual wiphy, is there a set of mac80211 callbacks we can start sharing? My motivation for sharing more callbacks comes from the eventual goal to support multiple virtual interfaces on the same radio each on a separate channel. The complexity of the drivers increase so it seems there is value in trying to reach more common ground. Luis -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
