Search Linux Wireless

Re: [PATCH 1/3] ath5k: remove stale function declarations, make some functions static

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Feb 19, 2010 at 6:15 PM, Pavel Roskin <proski@xxxxxxx> wrote:
> On Fri, 2010-02-19 at 08:44 -0500, John W. Linville wrote:
>> On Thu, Feb 18, 2010 at 08:28:02PM -0500, Pavel Roskin wrote:
>> Any reason not to just remove those functions instead of commenting
>> them out?
>
> I'm fine either way.  I tend to clean up more aggressively if I know
> that nobody will miss that code.  I wasn't sure in this case.

I don't think it will be a big deal if they disappear.  I think most of
them are just there because the original HAL had them.

Maybe one or two functions are waiting on an API in the stack to be useful
(e.g. antenna stuff), but we can always get these routines back from git
history if need be.

-- 
Bob Copeland %% www.bobcopeland.com
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux