Search Linux Wireless

Re: [PATCH 1/3] ath5k: remove stale function declarations, make some functions static

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2010-02-19 at 08:44 -0500, John W. Linville wrote:
> On Thu, Feb 18, 2010 at 08:28:02PM -0500, Pavel Roskin wrote:
> > Remove all unnecessary function declarations from ath5k.h.  Comment out
> > unused functions.  Remove ath5k_hw_get_tsf32(), which is too trivial to
> > be commented out.  Make functions static if suggested by sparse.  Make
> > ath5k_pm_ops static.
> 
> Any reason not to just remove those functions instead of commenting
> them out?

I'm fine either way.  I tend to clean up more aggressively if I know
that nobody will miss that code.  I wasn't sure in this case.

-- 
Regards,
Pavel Roskin
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux