Search Linux Wireless

Re: [RFC PATCH] staging: rtl8192su: remove dead code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Feb 17, 2010 at 10:51:14AM -0600, Larry Finger wrote:
> On 02/17/2010 02:19 AM, Frederic Leroy wrote:
> > Hello,
> > 
> > This patch removes some dead code in rtl8192su driver in staging against linux-2.6-stable tree.
> > Should I split it into smaller chunk ? 
> > As it is in staging, should I post it to linux-kernel@xxxxxxxxxxxxxxx ?
> 
> At 1400+ lines, the patch is a little large. I would recommend that you separate
> out the fixes for "ifdef RTL8190P" and "ifdef RTL8190U" into one patch, and the
> changes for "ifdef TO_DO_LIST" into a couple of patches. That should get the
> line count to below 500 in the individual patches.

I agree, that would be a better way to do this.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux