On 02/17/2010 02:19 AM, Frederic Leroy wrote: > Hello, > > This patch removes some dead code in rtl8192su driver in staging against linux-2.6-stable tree. > Should I split it into smaller chunk ? > As it is in staging, should I post it to linux-kernel@xxxxxxxxxxxxxxx ? At 1400+ lines, the patch is a little large. I would recommend that you separate out the fixes for "ifdef RTL8190P" and "ifdef RTL8190U" into one patch, and the changes for "ifdef TO_DO_LIST" into a couple of patches. That should get the line count to below 500 in the individual patches. These patches should be sent to GregKH with Cc: to linux-wireless and linux-kernel@xxxxxxxxxxxxxxxx I'm not sure how you sent this patch, but when I extracted it from my mailer (Thunderbird 3.0.1), it ended up with no line breaks. To get it as a usable file, I had to copy and paste. Coordinators get rather testy when presented with such patches. Larry -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html