Johannes Berg <johannes@xxxxxxxxxxxxxxxx> writes:
> On Tue, 2010-02-16 at 22:10 +0200, Kalle Valo wrote:
>
>> [NL80211_ATTR_COOKIE] = { .type = NLA_U64 },
>> [NL80211_ATTR_TX_RATES] = { .type = NLA_NESTED },
>> + [NL80211_ATTR_PS_STATE] = { .type = NLA_U8 },
>> };
>
> Looks good to me, though typically we use NLA_U32 for enums. Should we
> deviate from that because we won't ever extend this anyway, or should we
> use NLA_U32 to be more consistent?
Good point. In my opinion we should definitely use u32 for
consistency, there's no real reason to use u8 here. If it's ok for
you, I'll send v2 later today which uses u32.
Thank you for the review.
--
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
