On Wed, Feb 03, 2010 at 12:43:44PM -0800, Dan Williams wrote: > On Tue, 2010-02-02 at 15:34 +0100, Stanislaw Gruszka wrote: > > Patch prevents call set_wep_key() with zero key length. That fix long > > standing regression since commit c0380693520b1a1e4f756799a0edc379378b462a > > "airo: clean up WEP key operations". Additionally print call trace when > > someone will try to use improper parameters, and remove key.len = 0 > > assignment, because it is in not possible code path. > > What problem/regression does this actually fix? set_wep_key() should > never be called with zero-length key, There was one case where set_wep_key() was called instead of set_wep_tx_idx(). > so we should actually be returning > from that function instead of using WARN_ON() which would allow a > zero-length key to be set (which isn't really valid). Ok, changing that in v2 patch. Cheers Stanislaw -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
