On Tue, 2010-02-02 at 15:34 +0100, Stanislaw Gruszka wrote: > Patch prevents call set_wep_key() with zero key length. That fix long > standing regression since commit c0380693520b1a1e4f756799a0edc379378b462a > "airo: clean up WEP key operations". Additionally print call trace when > someone will try to use improper parameters, and remove key.len = 0 > assignment, because it is in not possible code path. What problem/regression does this actually fix? set_wep_key() should never be called with zero-length key, so we should actually be returning from that function instead of using WARN_ON() which would allow a zero-length key to be set (which isn't really valid). To disable a WEP key, the WEXT caller should be setting IW_ENCODE_DISABLED in the flags, and *not* sending WEP keys. Or if they do for some reason send WEP keys, they need to use the key flag IW_ENCODE_NOKEY to ensure they key is marked as "invalid" and ignored by the driver. Dan -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
