On Thu, 2010-01-21 at 12:44 -0800, Johannes Berg wrote:
> On Thu, 2010-01-21 at 12:31 -0800, wey-yi.w.guy@xxxxxxxxx wrote:
>
> > --- a/net/mac80211/mlme.c
> > +++ b/net/mac80211/mlme.c
>
> This is all in mlme.c, so ...
>
> > +static void ieee80211_update_dtim(struct ieee80211_sub_if_data *sdata,
> > + struct ieee80211_local *local,
> > + struct ieee80211_bss *bss)
> > +{
> > + if (!(local->hw.flags & IEEE80211_HW_SUPPORTS_PS))
> > + return;
> > +
> > + if (sdata->vif.type == NL80211_IFTYPE_STATION &&
>
> I don't think you need this check?
yes, that make sense.
>
> > + sdata->vif.bss_conf.dtim_period != bss->dtim_period) {
> > + sdata->vif.bss_conf.dtim_period = bss->dtim_period;
> > + ieee80211_hw_config(local, IEEE80211_CONF_CHANGE_PS);
> > + mutex_lock(&local->iflist_mtx);
> > + ieee80211_recalc_ps(local, -1);
> > + mutex_unlock(&local->iflist_mtx);
>
> And afaict recalc_ps() will call hw_config() if appropriate.
>
That is the part I am not sure, so I call the hw_config manually, since
you confirm hw_config will happen, then there is no point to call first
I will make those changes and submit again
Wey
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
