Hi Johannes, Agree, only iwlwifi use the dtim information now, but not sure it will be always true. Yes, we should recalculate the internal power save when it happen, I will make the changes and re-submit On Thu, 2010-01-21 at 08:32 -0800, Johannes Berg wrote: > On Thu, 2010-01-21 at 07:51 -0800, wey-yi.w.guy@xxxxxxxxx wrote: > > From: Wey-Yi Guy <wey-yi.w.guy@xxxxxxxxx> > > > > In current implementation, mac80211 send dtim_period update to driver during > > association, but if no NetworkManager or similar application perform scan > > operation, plus tim_ie is not part of probe response; mac80211 will not get > > beacon with dtim information later, then mac80211 will not pass the > > information to driver for update. > > Good catch. > > > Call ieee80211_hw_config() with IEEE80211_CONF_CHANGE_PS flag set to > > allow driver make correct dtim adjustment if dtim_period change detected. > > I don't think this is the right place or the right thing to do though, > this seems like an implementation detail from iwlwifi -- it only (and > maybe only it) uses the DTIM interval for power saving. > > However, the internal power saving stuff from mac80211 should also be > recalculated if this happens, and then we can probably call it a PS > change? > > johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
