2010/1/4 Luis R. Rodriguez <lrodriguez@xxxxxxxxxxx>: > On Mon, Jan 4, 2010 at 10:09 AM, Nick Kossifidis <mickflemm@xxxxxxxxx> wrote: >> 2010/1/4 Luis R. Rodriguez <lrodriguez@xxxxxxxxxxx>: >>> >>> + >>> +/* FLASH(EEPROM) Defines for AR531X chips */ >>> +#define AR5K_EEPROM_SIZE_LOWER 0x1b /* size info -- lower */ >>> +#define AR5K_EEPROM_SIZE_UPPER 0x1c /* size info -- upper */ >>> +#define AR5K_EEPROM_SIZE_UPPER_MASK 0xfff0 >>> +#define AR5K_EEPROM_SIZE_UPPER_SHIFT 4 >>> +#define AR5K_EEPROM_SIZE_ENDLOC_SHIFT 12 >>> + >> >> AR531X chips are SoCs, are you sure this comment is correct ? > > I got that from the legacy HAL, so just using that as a source of > documentation for this. > >> In the docs this marks the end of EAR section (and the end of >> checksum) for EEPROMs larger than 16k >> valid values for checksum end are 0x00000C0 to 0x0080000 > > I didn't see this used, just replicating what I saw in the legacy HAL > to match the code on Linux with what we have on other operating > systems. Not sure about the valid values for the checksum as per > documentation Vs what is implemented, I am just following what I see > implemented to ensure consistency. > >> Also to calculate EEPROM size (stored on the first 4 bits of 0x1c) you >> do this according to the docs >> 2 ^ (EEPROM size + 9) and valid values are from 1 to 11 (11 = 1MB) > > OK thanks so the eep_max should not be > 11 ? > I guess eep_max > (3 * AR5K_EEPROM_INFO_MAX) should be eep_max > 1024 -- GPG ID: 0xD21DB2DB As you read this post global entropy rises. Have Fun ;-) Nick -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
