W dniu 2 stycznia 2010 17:43 użytkownik Gábor Stefanik
<netrolller.3d@xxxxxxxxx> napisał:
> 2010/1/2 Rafał Miłecki <zajec5@xxxxxxxxx>:
>> W dniu 2 stycznia 2010 17:26 użytkownik Gábor Stefanik
>> <netrolller.3d@xxxxxxxxx> napisał:
>>> 2010/1/2 Rafał Miłecki <zajec5@xxxxxxxxx>:
>>>> Finally I've possibility to test my Christmas-gift N-PHY :) b43 didn't
>>>> really "notice" it, so I needed to write this little patch. Now b43 at least
>>>> look for firmware for my card.
>>>>
>>>> Does this patch look OK?
>>>>
>>>> This time I post from Opera mail so I hope white-spaces will be fine.
>>>>
>>>> From 9b3ea4f29b038f732aba737323e2f89b275ce1ab Mon Sep 17 00:00:00 2001
>>>> From: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= <zajec5@xxxxxxxxx>
>>>> Date: Sat, 2 Jan 2010 16:58:16 +0100
>>>> Subject: [PATCH] b43: Add new SSB's core id for BCM4328
>>>> MIME-Version: 1.0
>>>> Content-Type: text/plain; charset=UTF-8
>>>> Content-Transfer-Encoding: 8bit
>>>>
>>>> Following line shows my BCM4328 detected on SSB. We didn't include 0x0C rev.
>>>> ssb: Core 1 found: IEEE 802.11 (cc 0x812, rev 0x0C, vendor 0x4243)
>>>>
>>>> Signed-off-by: Rafał Miłecki <zajec5@xxxxxxxxx>
>>>> ---
>>>> drivers/net/wireless/b43/main.c | 1 +
>>>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>>>
>>>> diff --git a/drivers/net/wireless/b43/main.c
>>>> b/drivers/net/wireless/b43/main.c
>>>> index 098dda1..3aa45b8 100644
>>>> --- a/drivers/net/wireless/b43/main.c
>>>> +++ b/drivers/net/wireless/b43/main.c
>>>> @@ -110,6 +110,7 @@ static const struct ssb_device_id b43_ssb_tbl[] = {
>>>> SSB_DEVICE(SSB_VENDOR_BROADCOM, SSB_DEV_80211, 9),
>>>> SSB_DEVICE(SSB_VENDOR_BROADCOM, SSB_DEV_80211, 10),
>>>> SSB_DEVICE(SSB_VENDOR_BROADCOM, SSB_DEV_80211, 11),
>>>> + SSB_DEVICE(SSB_VENDOR_BROADCOM, SSB_DEV_80211, 12),
>>>
>>> Rev.14 is also missing (which AFAIK is used by some LP cards).
>>
>> Thanks, I'll post patch for that as well. Is adding this 0x0C (==13)
>> fine in this form? Or maybe we should use ifdef CONFIG_B43_NPHY for
>> some reason?
>
> I would say it's OK this way (BTW 0x0C == 12); we also didn't put
> rev.15 under CONFIG_B43_PHY_LP.
OK, thanks. And of course I've meant 0x0C == 12 :) After applying this
patch b43 won't try to init N-PHY device until CONFIG_B43_NPHY is set.
So I believe this patch is fine, thanks for sharing opinion :)
> (BTW I'm planning to rename CONFIG_B43_NPHY to CONFIG_B43_PHY_N in
> preparation for further PHY types, as well as the ability to only
> build certain PHYs as needed if EMBEDDED is set - a kernel for an
> LP-PHY SoC might save some space by not building G-PHY code.)
Heh, I was planning to do that :) OK, I'll focus on other stuff,
waiting for your patch :)
--
Rafał
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
