On Nov 23, 2009, at 11:49 AM, Michael Buesch wrote:
On Monday 23 November 2009 05:45:47 Larry Finger wrote:
On 11/19/2009 03:24 PM, Michael Buesch wrote:
This rewrites the error handling policies in the TX status handler.
It tries to be error-tolerant as in "try hard to not crash the
machine".
It won't recover from errors (that are bugs in the firmware or
driver),
because that's impossible. However, it will return a more or less
useful
error message and bail out. It also tries hard to use rate-limited
messages
to not flood the syslog in case of a failure.
This patch definitely helped open-source firmware, but it is not a
complete fix.
It is no fix _at_ _all_.
The patch does not change a single line of code that wasn't either
an assertion
or a machine crash before.
So it just transforms assertions into more verbose assertions and
crashes into
assertions without a crash.
debug: Out of order TX status report on DMA ring 1. Expected 114,
but got 146
Ok, this is what I expected.
Let's see what's going on. Here's the ring. o is unused, * is used.
ooooooooooooooo
***************************************************ooooooooooooooooooooooooooo
^ ^ ^
114 146 newest
oldest
So as you can see, the firmware reported a TX status for a frame
right in the middle of
the ringbuffer. The new code detects this now before getting a
double free and/or silent
memory corruption (freeing of used memory).
Hi Michael,
so you can observe this behavior at your site. Do you mind describing
the exact configuration? Maybe this time I can reproduce this
behavior, as I tried everything to make it happen. I also asked Larry
one of his boards and put it into several PCs but had no chance to
reproduce the crash. Could you please also report the neighboring
stations, the AP you are connected and so on.
Many thanks,
-Francesco
Informativa sulla privacy: http://help.ing.unibs.it/privacy.php
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
