On Mon, Oct 26, 2009 at 2:32 PM, Luis R. Rodriguez <lrodriguez@xxxxxxxxxxx> wrote: > On Mon, Oct 26, 2009 at 02:15:13PM -0700, Kalle Valo wrote: >> "Luis R. Rodriguez" <lrodriguez@xxxxxxxxxxx> writes: >> >> >> I think you should provide the size of hw_name to this function and >> >> use snprintf() to avoid writing out of bounds. >> > >> > I was going to do this but since I know the users of it and control >> > it seemed to not matter. I'll respin with this added, better to be careful. >> >> Yeah, you never know if someone (for example a crazy Finn just after a >> refreshing sauna) comes along, changes the function a bit "to clean it >> up" and creates a subtle bug ;) > > Ah yes, forgot about the crazy sauna fins, must fix now for sure. I have a couple of other fixes and since I no longer need to debug ath9k_hw_reset() I'm going to drop the last patch in this series. I'll resend this series then with the new patches. Luis -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
