Search Linux Wireless

Re: [RFC 1/3] mac80211: WIP - add operating BSSID to device configuration struct

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



ext Kalle Valo wrote:
Luciano Coelho <luciano.coelho@xxxxxxxxx> writes:

ext Johannes Berg wrote:
On Fri, 2009-10-16 at 15:27 +0300, Luciano Coelho wrote:

+	if (memcmp(sdata->local->hw.conf.oper_bssid,
+		   req->bss->bssid, ETH_ALEN)) {
+		config_changed |= IEEE80211_CONF_CHANGE_OPER_BSSID;
+		memcpy(sdata->local->hw.conf.oper_bssid,
+		       req->bss->bssid, ETH_ALEN);
+	}
+
+	ieee80211_hw_config(sdata->local, config_changed);
Is this really necessary before you can auth?
As we discussed on IRC, it is really needed.  We must always provide a
BSSID when changing channels in preparation for an association.

I'm not sure about the must part here. Maybe we can workaround it by
using ff:ff:ff:ff:ff bssid during authentication and association and
send a new join command after association. But that's not a clean
solution.

During one of our camps with TI, they told us that we must send the correct BSSID, otherwise we are going to have some side-effects. At least BT coext will be affected. And we have also seen the firmware send probe_reqs to ff:ff:ff:ff:ff:ff, which was causing problems. The firmware is simply not designed to do this. You probably also remember that we have recently removed extra joins from the wl1251 code as well, because they were causing some problems. So, from my point-of-view, this is unfortunately a must for wl1271. :(


--
Cheers,
Luca.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux