Search Linux Wireless

Re: [ipw3945-devel] [PATCH 02/17 v2.6.32] iwl3945: update iwl3945_apm_init()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Thank you all very much.

I don't have sophisticated power measurement devices to confirm these
fixes, and I've only tried patch 2/17, reporting back it on bug
http://bugzilla.intellinuxwireless.org/show_bug.cgi?id=2094 that the
problem is still not fixed with this patch applied only.


I originally tested temperature difference near the WLAN card
location. It's hard to compare overall laptop power usage between
Windows XP and Linux because there are other drivers that can make a
difference too.

Unfortunately, I don't have Windows XP anymore to compare since I've
upgraded my hard drive, but I'll be able to test further fixes by
watching the /sys/class/power_supply/BAT0/power_now on my X60s.

Can you describe your testing methodoloy? Are you testing just the
mini PCI card usage? Are you comparing to Windows XP or Vista drivers?

On Mon, Oct 12, 2009 at 9:57 PM, reinette chatre
<reinette.chatre@xxxxxxxxx> wrote:
> Hi John,
>
> On Mon, 2009-10-12 at 11:59 -0700, John W. Linville wrote:
>> On Fri, Oct 09, 2009 at 01:20:18PM -0700, Reinette Chatre wrote:
>> > From: Ben Cahill <ben.m.cahill@xxxxxxxxx>
>> >
>> > Update iwl3945_apm_init() to set up device registers in sequence most recently
>> > recommended by factory.
>> >
>> > Add resets for APMG interrupts and radio chip, formerly done only in
>> > iwl3945_apm_reset(); moving them here assures that apm_init() will do
>> > a complete job of preparing hardware not only after platform boot,
>> > but also after apm_stop() has executed (due to rfkill, ifconfig down,
>> > driver unload, etc.).  This is in preparation to completely remove apm_reset().
>> >
>> > Add some comments.
>> >
>> > Signed-off-by: Ben Cahill <ben.m.cahill@xxxxxxxxx>
>> > Signed-off-by: Reinette Chatre <reinette.chatre@xxxxxxxxx>
>>
>> Is this actually a regression?  Can you provide a reference to the bug report?
>
> This is something we discovered in the lab when we connected power
> measurement tools to the device when the interface was down. In this
> scenario the device is using a lot of power. This is not a regression
> from the previous kernel version, it is something that was broken for a
> while and only recently discovered.
>
> Patches 2/17 and 3/17 address this issue and the above comment applies
> to both.
>
> We are still looking into issues related to this discovery and you may
> see more fixes for this problem.
>
> Reinette
>
>
>
>
>
> ------------------------------------------------------------------------------
> Come build with us! The BlackBerry(R) Developer Conference in SF, CA
> is the only developer event you need to attend this year. Jumpstart your
> developing skills, take BlackBerry mobile applications to market and stay
> ahead of the curve. Join us from November 9 - 12, 2009. Register now!
> http://p.sf.net/sfu/devconference
> _______________________________________________
> Ipw3945-devel mailing list
> Ipw3945-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.sourceforge.net/lists/listinfo/ipw3945-devel
>
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux