On Tue, Aug 25, 2009 at 7:38 PM, Luis R. Rodriguez<lrodriguez@xxxxxxxxxxx>
> First thing I saw upon a quick review was we were relying on our own
> curband for RX instead of the cfg80211 hw->conf band. Now granted
> that *may* be updated properly, and it seems that may be the case,
Looks good at first glance, except it conflicts with changes I
recently posted. I'm all for getting rid of driver copies of stuff
in the stack.
> - /* NB: setup here so ath5k_rate_update is happy */
> - if (test_bit(AR5K_MODE_11A, ah->ah_modes))
> - ath5k_setcurmode(sc, AR5K_MODE_11A);
> - else
> - ath5k_setcurmode(sc, AR5K_MODE_11B);
> -
I take it ath5k_rate_update didn't really care?
> ath5k_chan_set(struct ath5k_softc *sc, struct ieee80211_channel *chan)
> {
> ATH5K_DBG(sc, ATH5K_DEBUG_RESET, "(%u MHz) -> (%u MHz)\n",
> - sc->curchan->center_freq, chan->center_freq);
> + sc->hw->conf.channel->center_freq, chan->center_freq);
So, does hw->conf.channel change before we're told to change channel,
or after?
> - if (chan) {
> - ath5k_hw_set_imr(ah, 0);
> - ath5k_txq_cleanup(sc);
> - ath5k_rx_stop(sc);
> -
> - sc->curchan = chan;
> - sc->curband = &sc->sbands[chan->band];
> - }
Unless I missed something I think we still want:
if (chan_change)
ath5k_chan_set(...);
> - ret = ath5k_hw_reset(ah, sc->opmode, sc->curchan, chan != NULL);
> + ret = ath5k_hw_reset(ah, sc->opmode, chan, chan_change);
There's just no synchronization of this stuff, not too surprising there
are races.
--
Bob Copeland %% www.bobcopeland.com
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
