On Tue, Aug 25, 2009 at 11:45:12AM -0700, Bob Copeland wrote: > On Tue, Aug 25, 2009 at 2:25 PM, Luis R. > Rodriguez<lrodriguez@xxxxxxxxxxx> wrote: > > This was printing the wrong value on the warning. While at it > > lets expand this warning to provide a little more useful > > information for debugging such as the band and hardware rate > > index when possible and clarify what the warning is actually > > printing. > > > rix = sc->rate_idx[sc->curband->band][hw_rix]; > > - if (WARN(rix < 0, "invalid hw_rix: %x\n", hw_rix)) > > + if (WARN(rix < 0, "invalid driver rate index: %x " > > + "(hw_rix: %x band: %s)\n", rix, hw_rix, > > + sc->curband->band ? "5 GHz" : "2.4 GHz")) > > rix will always be -1 here so no real need to print it. OK how about the band info, think that's useful? > I'm pretty sure band is going to be "the wrong one," because all > instances of this warning I've seen have been valid rate indexes, > like 1 mbit rates when scanning 5 ghz, I got this on 0x1b which is ATH5K_RATE_CODE_1M, I was suspecting the same. > which could indicate some > race condition with flushing the rx queue on channel changes. I'll see if I can reproduce somehow. > I haven't yet seen a hw rate we didn't know about. So you've seen this lately as well? Luis -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
