On Wed, Aug 12, 2009 at 11:13 AM, Jiri Slaby<jirislaby@xxxxxxxxx> wrote: > On 08/12/2009 06:58 PM, Luis R. Rodriguez wrote: >> --- a/drivers/net/wireless/ath/ath5k/base.c >> +++ b/drivers/net/wireless/ath/ath5k/base.c >> @@ -1157,17 +1157,18 @@ struct sk_buff *ath5k_rx_skb_alloc(struct ath5k_softc *sc, dma_addr_t *skb_addr) >> * fake physical layer header at the start. >> */ >> skb = ath_rxbuf_alloc(&sc->common, >> - sc->rxbufsize + sc->common.cachelsz - 1, > > What was the exact purpose of this? My guess is that we should map > starting at a next cache line boundary and put this aligned address to > the device instead? I've heard two theories: 1) AR5210 *required* it otherwise bad we would get bad data 2) Performance considerations I've tried checking internally but haven't found out yet the exact answer and this seems purely historical. I poked Sam Leffler to see if he recalls. But as we the 0x41 reset which I removed it seems to be best to leave unless we can be 100% sure we can remove this. Luis -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
