On Mon, Aug 03, 2009 at 08:54:47PM +0300, Nick Kossifidis wrote: > 2009/8/1 Johannes Berg <johannes@xxxxxxxxxxxxxxxx>: > > On Sat, 2009-08-01 at 10:24 +0200, Jiri Slaby wrote: > >> On 08/01/2009 10:21 AM, Johannes Berg wrote: > >> > Actually, jiffies are unsigned long > >> > >> Yeah, this is what I meant. I agree I messed it up when I didn't write > >> the unsigned explicitly. It might have been confusing, thanks for > >> pointing out. > > > > And, in addition to what you said, the code shouldn't divide jiffies, it > > should multiply the timeout, add it to the start time, and then use > > time_is_after_jiffies() or so. > > > > johannes > > ACK will resend asap ;-) Last I saw in this thread... Can we have a clean repost of the whole series (including proper Signed-off-by and any Acked-by, Tested-by, etc)? Also, in the future I think it would be good for you to take some of the comments from Luis to heart -- explain the 'why' not the 'what' in the changelogs, do one thing per patch, etc. I'm going to drop the original 1-4 now and wait for a clean repost. Thanks, John -- John W. Linville Someday the world will need a hero, and you linville@xxxxxxxxxxxxx might be all we have. Be ready. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html