On Monday 03 August 2009 11:13:37 Michael Buesch wrote: > On Monday 03 August 2009 00:18:22 Gábor Stefanik wrote: > > Implement baseband init for rev.0 and rev.1 LP PHYs. Convert > > boardflags_hi values to defines. > > Implement b43_phy_copy for easier copying between registers, as needed > > by LP-PHY init. > > > + if (bus->sprom.boardflags_hi& B43_BFH_FEM_BT)&& > > + (bus->chip_id == 0x5354)&& > > + (bus->chip_package == SSB_CHIPPACK_BCM4712S)) { > > + b43_phy_set(dev, B43_LPPHY_CRSGAIN_CTL, 0x0006); > > + b43_phy_write(dev, B43_LPPHY_GPIO_SELECT, 0x0005); > > + b43_phy_write(dev, B43_LPPHY_GPIO_OUTEN, 0xFFFF); > > + b43_hf_write(dev, b43_hf_read | 0x0800ULL<< 32); > > + } > > The HF write is wrong. Read the specification: > http://bcm-v4.sipsolutions.net/802.11/Mhf > > Patch otherwise looks ok. Sorry, I replied to the wrong mail. But this does also apply to V2 patch. -- Greetings, Michael. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html