Search Linux Wireless

Re: [PATCH v2] mac80211: Do not try to associate with an empty SSID

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jouni Malinen <jouni.malinen@xxxxxxxxxxx> writes:

> It looks like some programs (e.g., NM) are setting an empty SSID with
> SIOCSIWESSID in some cases. This seems to trigger mac80211 to try to
> associate with an invalid configuration (wildcard SSID) which will
> result in failing associations (or odd issues, potentially including
> kernel panic with some drivers) if the AP were to actually accept this
> anyway).
>
> Only start association process if the SSID is actually set. This
> speeds up connection with NM in number of cases and avoids sending out
> broken association request frames.
>
> Signed-off-by: Jouni Malinen <jouni.malinen@xxxxxxxxxxx>

Thanks, I think I have an internal bug report about a similar issue and
I hope this fixes that as well. But I need to investigate to be sure.

> v2: Allow disassociation in ssid_len=0 case and only avoid starting a
> new association. This function is difficult to understand and for now, I
> just want to fix the critical issue here. Eventually, this code should
> be redesigned or at least commented clearly.

Like we have talked earlier in this list, mlme.c requires a rewrite.

-- 
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux