It looks like some programs (e.g., NM) are setting an empty SSID with
SIOCSIWESSID in some cases. This seems to trigger mac80211 to try to
associate with an invalid configuration (wildcard SSID) which will
result in failing associations (or odd issues, potentially including
kernel panic with some drivers) if the AP were to actually accept this
anyway).
Only start association process if the SSID is actually set. This
speeds up connection with NM in number of cases and avoids sending out
broken association request frames.
Signed-off-by: Jouni Malinen <jouni.malinen@xxxxxxxxxxx>
---
net/mac80211/mlme.c | 8 ++++++++
1 file changed, 8 insertions(+)
v2: Allow disassociation in ssid_len=0 case and only avoid starting a
new association. This function is difficult to understand and for now, I
just want to fix the critical issue here. Eventually, this code should
be redesigned or at least commented clearly.
--- wireless-testing.orig/net/mac80211/mlme.c 2009-06-11 13:38:01.000000000 +0300
+++ wireless-testing/net/mac80211/mlme.c 2009-06-11 18:08:39.000000000 +0300
@@ -2445,6 +2445,14 @@ void ieee80211_sta_req_auth(struct ieee8
ieee80211_set_disassoc(sdata, true, true,
WLAN_REASON_DEAUTH_LEAVING);
+ if (ifmgd->ssid_len == 0) {
+ /*
+ * Only allow association to be started if a valid SSID
+ * is configured.
+ */
+ return;
+ }
+
if (!(ifmgd->flags & IEEE80211_STA_EXT_SME) ||
ifmgd->state != IEEE80211_STA_MLME_ASSOCIATE)
set_bit(IEEE80211_STA_REQ_AUTH, &ifmgd->request);
--
Jouni Malinen PGP id EFC895FA
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
