Search Linux Wireless

Re: [PATCH] ath9k: Add sanity check for beacon_int in adhoc/mesh case

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2009-06-01 at 17:05 +0300, Jouni Malinen wrote:
> On Mon, 2009-06-01 at 06:30 -0700, Kalle Valo wrote:
> > Jouni Malinen <jouni.malinen@xxxxxxxxxxx> writes:
> > 
> > > +     /*
> > > +      * It looks like mac80211 may end up using beacon interval of zero in
> > > +      * some cases (at least for mesh point). Avoid getting into an
> > > +      * infinite loop by using a bit safer value instead..
> > > +      */
> > > +     if (intval == 0)
> > > +             intval = 100;
> > 
> > Maybe a big fat warning here would help with debugging the issue?
> 
> If we agree that this should never happen, such a thing could be added.
> Though, it would probably be better to place that in mac80211 so that it
> would catch the issue with any driver. The beacon_int=0 notification is
> not really in any way specific to ath9k; only this workaround for driver
> behavior is.

Has anyone identified why this happens? :) I'm not particularly happy
with the mesh configuration code anyway, but this is a stupid thing that
should be trivial to fix.

johannes

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux