Hi Johannes! On Mon, 01 Jun 2009, Johannes Berg wrote: > On Mon, 2009-06-01 at 09:28 -0300, Henrique de Moraes Holschuh wrote: > > On Mon, 01 Jun 2009, Alan Jenkins wrote: > > >> See, Henrique says that the use case is Thinkpads which store the > > >> previous state in the BIOS. But that matters to you only if you use a > > >> mixture of operation systems, which we don't have to support. > > > > Well, if you do all in userspace, how do you propose to avoid the usual race > > conditions of the sort "radio starts on, but it should have started off", > > etc? You'd have to kick the radios off on rfkill module load for safety, > > and that will also cause nastyness (it kicks my built-in wlan > > (eeepcargh)/bluetooth(most)/wwan(most) off bus, then hotplugs it again!). > > Have you bothered reading the code? If you turn things off with > CHANGE_ALL that applies to hot-plugged devices too. I mean platform devices which remember state. Those will be turned on/off by the platform firmware at boot and often at resume time, and overriding them in rfkill (especially if it is done later, by a rfkilld) will cause some flicker (on/off/on, off/on/off) in certain situations. This is a regression, because the current interface doesn't suffer this limitation. Also, remember that this on/off stuff CAN mean kicking devices off-bus, that's very usual for everything other than WLAN, so it can be a lot more annoying than just turning a transmitter off for a moment. I certainly expect whatever the current global state to be applied to all new devices getting registered, that is not something I would complain about. -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
