On Thu, May 21, 2009 at 03:56:28PM +0200, Johannes Berg wrote: > On Thu, 2009-05-21 at 09:38 -0400, John W. Linville wrote: > > On Thu, May 21, 2009 at 11:21:59AM +0200, Johannes Berg wrote: > > > On Thu, 2009-05-21 at 15:09 +0800, Zhu Yi wrote: > > > > > > > > Isn't lib80211 a better place for those ? > > > > > Its purpose is sharing code between fullmac and softmac drivers. > > > > > > > > These functions are moved from mac80211 which currently doesn't link > > > > with lib80211. Johannes might have more to comment. > > > > > > Yeah, lib80211's stated purpose is to share code, but on the other hand > > > code that mac80211 and fullmac drivers may need seems better suited in > > > cfg80211 since lib80211 also ships a large code bit of crypto routines > > > etc. that are just useless for this and mac80211. > > > > The crypto stuff is mostly in separate modules. > > > > I would rather see these in lib80211, but I'll work that out myself. > > Heh. And I asked them to put it here... Then again, lib80211_crypt_* > only exists for hostap and ipw2x00, so maybe we should separate that out > into a separate lib80211_crypt module? That would leave lib80211 only > with print_ssid, of course... > > Basically I still think having lib80211 is pretty much pointless since > all future fullmac drivers and mac80211 all need to use cfg80211. I like the logical separation for now. At some point they can probably be viewed as a single unit, but even then I think lib80211 will be a better name for the amalgamation... :-) John -- John W. Linville Someday the world will need a hero, and you linville@xxxxxxxxxxxxx might be all we have. Be ready. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
