On Wed, May 13, 2009 at 3:37 PM, Luis R. Rodriguez <lrodriguez@xxxxxxxxxxx> wrote: > On Wed, May 13, 2009 at 3:35 PM, Johannes Berg > <johannes@xxxxxxxxxxxxxxxx> wrote: >> On Wed, 2009-05-13 at 15:29 -0700, Luis R. Rodriguez wrote: >> >>> >> queue_regulatory_request(request); >>> >> >>> >> + /* >>> >> + * This ensures last_request is populated once modules >>> >> + * come swinging in and calling regulatory hints and >>> >> + * wiphy_apply_custom_regulatory(). >>> >> + */ >>> >> + flush_scheduled_work(); >>> >> + >>> > >>> > Umm, this is a little stupid, first you queue it and then you flush the >>> > workqueue... Why not call the function that runs off the workqueue >>> > directly? >>> >>> That was the original approach -- but then we went on a bagwagon on >>> getting all these regulatory hints through the workqueue. I can >>> address for for wireless-testing but not sure what path we prefer for >>> stable. The above one liner seems small enough and would be nice to >>> get confirmation from a user on stable. >> >> Yeah definitely the way to go for stable, and we can als put it into >> wireless-testing. But I think ultimately we should just refactor what is >> necessary and just call the function that would otherwise run off the >> workqueue. Can do that after this patch though. > > OK -- will work on that next. BTW please feel free to add: Tested-by: Alan Jenkins <alan-jenkins@xxxxxxxxxxxxxx> Luis -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
