Search Linux Wireless

Re: [PATCH 4/4] cfg80211: fix race between core hint and driver's custom apply

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, May 13, 2009 at 3:08 PM, Johannes Berg
<johannes@xxxxxxxxxxxxxxxx> wrote:
> On Wed, 2009-05-13 at 17:04 -0400, Luis R. Rodriguez wrote:
>
>>       queue_regulatory_request(request);
>>
>> +     /*
>> +      * This ensures last_request is populated once modules
>> +      * come swinging in and calling regulatory hints and
>> +      * wiphy_apply_custom_regulatory().
>> +      */
>> +     flush_scheduled_work();
>> +
>
> Umm, this is a little stupid, first you queue it and then you flush the
> workqueue... Why not call the function that runs off the workqueue
> directly?

That was the original approach -- but then we went on a bagwagon on
getting all these regulatory hints through the workqueue. I can
address for for wireless-testing but not sure what path we prefer for
stable. The above one liner seems small enough and would be nice to
get confirmation from a user on stable.

  Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux