On Tue, 2009-05-12 at 17:15 +0200, Christian Lamparter wrote: > On Tuesday 12 May 2009 08:39:49 Johannes Berg wrote: > > On Tue, 2009-05-12 at 01:09 +0200, Christian Lamparter wrote: > > > > > + if ((ar->tx_stats[i].len < ar->tx_stats[i].limit) && > > > + (ieee80211_queue_stopped(ar->hw, i))) > > > + ieee80211_wake_queue(ar->hw, i); > > > > There's no reason to test _stopped first, and doing so is racy. > uhh, agreed _stopped is not necessary, but where's the race condition? Well if _stopped returns false but you were just about to stop you're now racing against whoever is stopping. johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
